[webkit-reviews] review granted: [Bug 90974] [BlackBerry] Some small changes in network code : [Attachment 152204] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 07:44:56 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 90974: [BlackBerry] Some small changes in network code
https://bugs.webkit.org/show_bug.cgi?id=90974

Attachment 152204: Patch
https://bugs.webkit.org/attachment.cgi?id=152204&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152204&action=review


Looks good.

> Source/WebCore/platform/network/blackberry/NetworkJob.h:83
> +    virtual int status() { return m_extendedStatusCode; }

Could be const.

> Source/WebCore/platform/network/blackberry/SocketStreamHandle.h:60
> +    virtual int status() { return m_status; }

Could be const.


More information about the webkit-reviews mailing list