[webkit-reviews] review granted: [Bug 90962] [BlackBerry] We shouldn't call didFinishLoading for the old request when a new request has been sent by notifyAuthReceived. : [Attachment 151868] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 07:36:51 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Jason <jason.liu at torchmobile.com.cn>'s
request for review:
Bug 90962: [BlackBerry] We shouldn't call didFinishLoading for the old request
when a new request has been sent by notifyAuthReceived.
https://bugs.webkit.org/show_bug.cgi?id=90962

Attachment 151868: Patch
https://bugs.webkit.org/attachment.cgi?id=151868&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151868&action=review


Looks good.

>>> Source/WebCore/ChangeLog:11
>>> +	     We should do as 3XX.
>> 
>> There is no PR for this. I just find this problem when fixing another pr.
> 
> Any PR? Internal review?

Ok, you could add Joe Mason as internal reviewer before landing, up to you.


More information about the webkit-reviews mailing list