[webkit-reviews] review canceled: [Bug 91208] Restructure V8Utilities::extractTransferables() with help of toV8Sequence() : [Attachment 152208] Patch

[bugzilla-daemon at webkit.org]

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has canceled Vineet Chaudhary
(vineetc) <rgf748 at motorola.com>'s request for review:
Bug 91208: Restructure V8Utilities::extractTransferables() with help of
toV8Sequence()
https://bugs.webkit.org/show_bug.cgi?id=91208

Attachment 152208: Patch
https://bugs.webkit.org/attachment.cgi?id=152208&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
(In reply to comment #3)
> (From update of attachment 152208 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=152208&action=review
>
> > Source/WebCore/bindings/v8/V8Utilities.cpp:-105
> > -	 if (value->IsArray()) {
> > -	     v8::Local<v8::Array> array = v8::Local<v8::Array>::Cast(value);
> > -	     length = array->Length();
> > -	 } else {
>
> Is it OK to remove this part? I mean, the code might be:
>
>   if (value->IsArray()) {
>     v8::Local<v8::Array> array = v8::Local<v8::Array>::Cast(value);
>     length = array->Length();
>   } else {
>     if (toV8Sequence(value, length).IsEmpty())
>	return false;
>   }

Though removing IsArray() check doesn't cause any behavioural change but having
it will surely faster than every time calling toV8Sequence(). Thanks!!

> New failing tests:
>
http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attrib
utes_exist_in_object.html

Regarding failing perf test though I have rebased test expected but I really
not sure if that is expected?