[webkit-reviews] review denied: [Bug 90659] Web Inspector: Option to filter search based on source type in Advanced-Search : [Attachment 152215] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied sam <dsam2912 at gmail.com>'s
request for review:
Bug 90659: Web Inspector: Option to filter search based on source type in
Advanced-Search
https://bugs.webkit.org/show_bug.cgi?id=90659

Attachment 152215: Patch
https://bugs.webkit.org/attachment.cgi?id=152215&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152215&action=review


> Source/WebCore/inspector/front-end/AdvancedSearchController.js:150
> +	       var searchScopeToken = searchConfig.query.split("
")[0].split(":");

What about
" file:*.js query"
" query file:*.js"? r- for this.

And even more tricky
" query file:*.js file:name query2"?
Codesearch supports them all and if are making this search smarter we should
probably support them too.