[webkit-reviews] review requested: [Bug 89198] Web Inspector: too many hardcoded strings in InspectorBackendDispatcher. : [Attachment 150997] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 03:44:06 PDT 2012


Peter Rybin <prybin at chromium.org> has asked  for review:
Bug 89198: Web Inspector: too many hardcoded strings in
InspectorBackendDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=89198

Attachment 150997: Patch
https://bugs.webkit.org/attachment.cgi?id=150997&action=review

------- Additional Comments from Peter Rybin <prybin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150997&action=review


>> Source/WebCore/inspector/CodeGeneratorInspector.py:1981
>> +	    size_t length = ARRAY_SIZE(commandNames);
> 
> It should be WTF_ARRAY_LENGTH(commandNames), not sure why compiler didn't
complain about it. Is ARRAY_SIZE defined somewhere in WebKit, I only see 2
places
(http://code.google.com/p/chromium/source/search?q=define%5CsARRAY_SIZE+file%3A
WebKit&origq=define%5CsARRAY_SIZE+file%3AWebKit&btnG=Search+Trunk), none of
which should be visible here?

Actually I made my own -- didn't know the right name for search. Replaced.


More information about the webkit-reviews mailing list