[webkit-reviews] review granted: [Bug 89962] Change the timing of form state restore : [Attachment 152178] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 13 02:30:49 PDT 2012
Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 89962: Change the timing of form state restore
https://bugs.webkit.org/show_bug.cgi?id=89962
Attachment 152178: Patch
https://bugs.webkit.org/attachment.cgi?id=152178&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152178&action=review
I hope that the restoring policy be clarified or documented somehow.
For example, Can we add kind of "dirty bit" for each state to prevent
accidental duplication?
> Source/WebCore/ChangeLog:8
> + For a preparation to fix a form identification problem, restore
controls
Could you point the bug id here?
> Source/WebCore/ChangeLog:35
> + Add isFormControlElementWithState() for
FormController::restoreControlStateIn().
Nit: Added
> Source/WebCore/ChangeLog:38
> + Some code is moved to FormController:restoreControlStateFor().
Nit: s/is/was/
> Source/WebCore/html/FormController.cpp:34
> + // Assume contorl with form attribute have no owners because we restores
s/contorl/controls/
s/restores/restore/
More information about the webkit-reviews
mailing list