[webkit-reviews] review granted: [Bug 84827] Make calendar pickers testable : [Attachment 151888] Patch 6

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 84827: Make calendar pickers testable
https://bugs.webkit.org/show_bug.cgi?id=84827

Attachment 151888: Patch 6
https://bugs.webkit.org/attachment.cgi?id=151888&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151888&action=review


Cool! this is a great example of "creating mocks in internals" approach.

> Source/WebCore/testing/MockPagePopupDriver.cpp:77
> +    WebCoreTestSupport::injectPagePopupController(contentFrame,
m_controller.get());

Why not just make "pagePopupController" an attribute of Internals? Then we can
get rid of V8 custom part.

> Source/WebKit/chromium/src/WebViewImpl.h:117
> +		       public WebLayerTreeViewClient,

Nit: commas should be aligned to ":"