[webkit-reviews] review granted: [Bug 91178] RadioNodeList is not updated upon input type change : [Attachment 152119] Fixes the bug

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov (on vacation until 7/18) <ap at webkit.org> has granted
Ryosuke Niwa <rniwa at webkit.org>'s request for review:
Bug 91178: RadioNodeList is not updated upon input type change
https://bugs.webkit.org/show_bug.cgi?id=91178

Attachment 152119: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=152119&action=review

------- Additional Comments from Alexey Proskuryakov (on vacation until 7/18)
<ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152119&action=review


r=me since the change makes sense, but please investigate regression test
failure.

> Source/WebCore/ChangeLog:16
> +	   * dom/Document.h: Renamed InvalidateOnIdNameForAttrChange to
InvalidateOnFormAttrChange
> +	   since listing all attribute name isn't useful at this point.

The new name is quite cryptic. If it's not possible to describe what this
option does, perhaps its name should just say when it's used (even something
blunt like InvalidateForRadioGroup).