[webkit-reviews] review canceled: [Bug 91188] DFG CFA may get overzealous in loops that have code that must exit : [Attachment 152149] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 21:41:58 PDT 2012


Gavin Barraclough <barraclough at apple.com> has canceled Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 91188: DFG CFA may get overzealous in loops that have code that must exit
https://bugs.webkit.org/show_bug.cgi?id=91188

Attachment 152149: the patch
https://bugs.webkit.org/attachment.cgi?id=152149&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152149&action=review


> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:60
> +	       m_insertionSetForFolding.execute(*block);

This may insert the phantoms in the wrong place, Phi will fix.


More information about the webkit-reviews mailing list