[webkit-reviews] review denied: [Bug 40300] Web Inspector: [JSC] implement script source editing : [Attachment 152134] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 12 19:51:26 PDT 2012
Filip Pizlo <fpizlo at apple.com> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 40300: Web Inspector: [JSC] implement script source editing
https://bugs.webkit.org/show_bug.cgi?id=40300
Attachment 152134: Patch
https://bugs.webkit.org/attachment.cgi?id=152134&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152134&action=review
> Source/JavaScriptCore/interpreter/Interpreter.cpp:1094
> -JSValue Interpreter::execute(ProgramExecutable* program, CallFrame*
callFrame, ScopeChainNode* scopeChain, JSObject* thisObj)
> +JSValue Interpreter::execute(ProgramExecutable* program, CallFrame*
callFrame, ScopeChainNode* scopeChain, JSObject* thisObj, bool compileOnly)
Split this into two methods, one that compiles, and the other that compiles and
executes.
More information about the webkit-reviews
mailing list