[webkit-reviews] review denied: [Bug 90940] Add RegisterProtocolHandlerClient | RegisterProtocolHandlerController to the Modules/protocolhandler : [Attachment 151881] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 12 17:34:56 PDT 2012
Hajime Morrita <morrita at google.com> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 90940: Add RegisterProtocolHandlerClient |
RegisterProtocolHandlerController to the Modules/protocolhandler
https://bugs.webkit.org/show_bug.cgi?id=90940
Attachment 151881: Patch
https://bugs.webkit.org/attachment.cgi?id=151881&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
r- for cr-linux redness.
I noticed that we can get rid of RegisterProtocolHandlerController by
making NavigatorRegisterProtocolHandler RefCountedSupplement<Page> instead of
Supplement<Navigator>. Even though NavigatorRegisterProtocolHandler has
m_frame, no one uses it. So it doesn't need any frame/document specific state
and can be a page-supplement.
More information about the webkit-reviews
mailing list