[webkit-reviews] review granted: [Bug 91156] Fix QtWebKit build with OpenGLES after GC3D/E3D refactor : [Attachment 152089] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 16:47:49 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has granted Lauro Moura Maranhao Neto
<lauro.neto at openbossa.org>'s request for review:
Bug 91156: Fix QtWebKit build with OpenGLES after GC3D/E3D refactor
https://bugs.webkit.org/show_bug.cgi?id=91156

Attachment 152089: Patch
https://bugs.webkit.org/attachment.cgi?id=152089&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152089&action=review


This looks good to me, but before landing I want to understand why reshapeFBOs
was removed in the first place.

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:73
> +    // unsupported

Call notImplemented() instead of a comment.


More information about the webkit-reviews mailing list