[webkit-reviews] review granted: [Bug 91116] WebContext::getWebCoreStatistics() causes crash if no m_process : [Attachment 152070] Proposed patch with test case.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Josh Hawn
<jhawn at apple.com>'s request for review:
Bug 91116: WebContext::getWebCoreStatistics() causes crash if no m_process
https://bugs.webkit.org/show_bug.cgi?id=91116

Attachment 152070: Proposed patch with test case.
https://bugs.webkit.org/attachment.cgi?id=152070&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152070&action=review


> Source/WebKit2/UIProcess/WebContext.cpp:-923
>  void WebContext::getWebCoreStatistics(PassRefPtr<DictionaryCallback>
prpCallback)
>  {
> -    RefPtr<DictionaryCallback> callback = prpCallback;

Ugh, we don't do hungarian notation.

This method is really confusing. It's called getWebCoreStatistics() but doesn't
return anything.

> Source/WebKit2/UIProcess/WebContext.cpp:930
> +    RefPtr<DictionaryCallback> callback = prpCallback;
>      uint64_t callbackID = callback->callbackID();
>      m_dictionaryCallbacks.set(callbackID, callback.get());

I think this RefPtr is doing an extra retain. Won't m_dictionaryCallbacks have
the owning reference?