[webkit-reviews] review granted: [Bug 91047] Regression (r122359) Layout Test html5lib/runner.html is failing : [Attachment 152050] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 91047: Regression (r122359) Layout Test html5lib/runner.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91047

Attachment 152050: Patch
https://bugs.webkit.org/attachment.cgi?id=152050&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152050&action=review


>
LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt:2

> +ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable
true
> +ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable
true

Nit: It would be nicer if the test said PASS/FAIL rather than ALERT.  Maybe use
js-test-pre?

> LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:8
> +    XHTML-MP is used for mobile documents which are assumed to be designed
for
> +    handheld devices, hence using the viewport size as the initial
containing

Nit: Since this is a dumpAsText test, should we just put this in a <p>?