[webkit-reviews] review granted: [Bug 87546] Implied minimum size of flex items is min-content : [Attachment 152045] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 87546: Implied minimum size of flex items is min-content
https://bugs.webkit.org/show_bug.cgi?id=87546

Attachment 152045: Patch
https://bugs.webkit.org/attachment.cgi?id=152045&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152045&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:754
> +	   Length min = isHorizontalFlow() ? child->style()->minWidth() :
child->style()->minHeight();

Nit: childMin or maybe even childMainAxisMin

> Source/WebCore/rendering/RenderFlexibleBox.cpp:805
> +	   if (childSize < minContent)
> +	       return minContent;

Nit: You could either return std::max(childSize, minContent) or assign that
value to childSize.

> LayoutTests/css3/flexbox/flex-item-min-size.html:41
> +    <div>Tests that flex items have default min-size to min-content in the
main axis direction.</div>

It would be nice to test this for other writing modes.