[webkit-reviews] review denied: [Bug 11355] Overflow: auto; in 2 cascaded boxes, outer having overflow: auto; , inner having overflow: auto; height: 100%; width: 200%; - Renders scrollbars on cascaded block elements in wrong way : [Attachment 151995] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 11355: Overflow: auto; in 2 cascaded boxes, outer having overflow: auto;,
inner having overflow: auto; height: 100%; width: 200%; - Renders scrollbars on
cascaded block elements in wrong way
https://bugs.webkit.org/show_bug.cgi?id=11355

Attachment 151995: Patch
https://bugs.webkit.org/attachment.cgi?id=151995&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151995&action=review


> Source/WebCore/ChangeLog:14
> +	   Subtracting the height of the scrollbar from the client height when
the client has percentage width.

I think you meant to say "client has percentage height."

> Source/WebCore/rendering/RenderBox.cpp:2147
> +	   result -= LayoutUnit(cb->scrollbarLogicalHeight());

You don't want to go negative here, e.g., if the scrollbar height is > than the
available height. You should max with 0, e.g., result = max(0, result -
cb->scrollbarLogicalHeight());

I am assuming that isn't handled later. If it is, disregard.

Don't you need to patch the replaced case also? I would like to see a test
where the inner object is a replaced element like an image, since I suspect you
need to patch the replaced logical height computation as well? Specifically
computeReplacedLogicalHeightUsing.