[webkit-reviews] review granted: [Bug 90951] [Chromium] Fix bugs in HarfBuzzShaper : [Attachment 151858] Patch V2

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 90951: [Chromium] Fix bugs in HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=90951

Attachment 151858: Patch V2
https://bugs.webkit.org/attachment.cgi?id=151858&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151858&action=review


> LayoutTests/ChangeLog:13
> +	   * fast/text/harfbuzz-script-order.html: Added.
> +	   * fast/text/harfbuzz-selection.html: Added.

It's a little weird that the tests have the name harfbuzz in them since they
might not always use harfbuzz.	Maybe we should use a different name like
complex-text-script-order.html or shaping-script-order.html.  You might want to
just make a subdirectory for these tests (fast/text/complex or
fast/text/shaping or fast/text/font-feature-setting) and just skip the
directory on other platforms.