[webkit-reviews] review granted: [Bug 91111] Move TextureMapperAnimation and texmap/LayerTransform to platform/graphics : [Attachment 151979] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 91111: Move TextureMapperAnimation and texmap/LayerTransform to
platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=91111

Attachment 151979: Patch
https://bugs.webkit.org/attachment.cgi?id=151979&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151979&action=review


> Source/WebCore/ChangeLog:10
> +	   TextureMapperAnimation and LayerTransform are not specific to
TextureMapper, and we want
> +	   to use them for other purposes as well. Moving them to
platform/graphics would make that
> +	   more explicit.

What about a namechange then to the former?

> Source/WebCore/GNUmakefile.list.am:6128
> +	Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp \
> +	Source/WebCore/platform/graphics/GraphicsLayerTransform.h \
> +	Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp \
> +	Source/WebCore/platform/graphics/GraphicsLayerAnimation.h \

ah you did that :-)

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp:27
> +#if USE(TEXTURE_MAPPER)
> +namespace WebCore {

You still want this guard?