[webkit-reviews] review granted: [Bug 91075] [Qt] Increase the drawing performance by merging dirty rects. : [Attachment 151917] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 09:08:43 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 91075: [Qt] Increase the drawing performance by merging dirty rects.
https://bugs.webkit.org/show_bug.cgi?id=91075

Attachment 151917: Patch
https://bugs.webkit.org/attachment.cgi?id=151917&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151917&action=review


Awesome!

> Source/WebKit/qt/Api/qwebframe.cpp:363
> +    const unsigned int cRectThreshold = 10;
> +    const float cWastedSpaceThreshold = 0.75f;

We can do without the c prefix.


More information about the webkit-reviews mailing list