[webkit-reviews] review granted: [Bug 91100] [GTK] Add API to get HTTPS status to WebKit2 GTK+ : [Attachment 151967] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 09:06:30 PDT 2012


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 91100: [GTK] Add API to get HTTPS status to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=91100

Attachment 151967: Patch
https://bugs.webkit.org/attachment.cgi?id=151967&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151967&action=review


> Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp:26
> +WebKitTestServer::WebKitTestServer(bool ssl)

I think it would be nice to use an enum here, so that instantiating a server
looks like this:

WebKitTestServer(EnableSSL)

or something similar.


More information about the webkit-reviews mailing list