[webkit-reviews] review granted: [Bug 88325] Web Inspector: Implement message loop instrumentation for timeline : [Attachment 151890] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 88325: Web Inspector: Implement message loop instrumentation for timeline
https://bugs.webkit.org/show_bug.cgi?id=88325

Attachment 151890: Patch
https://bugs.webkit.org/attachment.cgi?id=151890&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151890&action=review


> Source/WebCore/inspector/front-end/TimelinePanel.js:375
> +	       /** @const */ var frameContainerBorderWidth = 1;

/** @const */ const frameContainerBorderWidth = 1;

> Source/WebCore/inspector/front-end/TimelinePanel.js:812
> +		   if (Math.ceil(lastRight) >= Math.floor(left)) {

We may end up with as many chunks as pixels. You should introduce the minimal
chunk width of 3px and make sure that gaps are longer than 3px as well. Or
alternatively you could render it all using canvas!