[webkit-reviews] review granted: [Bug 90974] [BlackBerry] Some small changes in network code : [Attachment 151684] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 07:48:32 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 90974: [BlackBerry] Some small changes in network code
https://bugs.webkit.org/show_bug.cgi?id=90974

Attachment 151684: Patch
https://bugs.webkit.org/attachment.cgi?id=151684&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151684&action=review


Looks good.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:483
> +		   m_status = isError(m_extendedStatusCode) ?
BlackBerry::Platform::FilterStream::StatusNetworkError:
BlackBerry::Platform::FilterStream::StatusSuccess;

Style nit, please add a space before ':'


More information about the webkit-reviews mailing list