[webkit-reviews] review denied: [Bug 90277] Web Inspector: added Paint events for Images to TimelineAgent : [Attachment 151904] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90277: Web Inspector: added Paint events for Images to TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90277

Attachment 151904: Patch
https://bugs.webkit.org/attachment.cgi?id=151904&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151904&action=review


> Source/WebCore/ChangeLog:8
> +	   * English.lproj/localizedStrings.js:

Please explain what has changed and why.

> Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp:86
> +	   InspectorInstrumentation::willDecodeImage("BMP");

I can see existing TRACE_EVENT called from within decode. Is there a reason we
want to put our instrumentation elsewhere? Also, could use introduce RAII
concept (InspectorInstrumentation::TraceEvent("ImageDecode") trace;) for this
kind of instrumentation?