[webkit-reviews] review denied: [Bug 90881] [Qt][WK2] Implement GraphicsSurface for Linux/GLX. : [Attachment 151907] patch for review. - fixed issues as previously commented.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 90881: [Qt][WK2] Implement GraphicsSurface for Linux/GLX.
https://bugs.webkit.org/show_bug.cgi?id=90881

Attachment 151907: patch for review. - fixed issues as previously commented.
https://bugs.webkit.org/attachment.cgi?id=151907&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151907&action=review


> Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:193
> +	       QCoreApplication::processEvents();

Hm.... this seems risky. Any other way to do it?

> Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:216
> +    QWindow* m_surface;
> +    QOpenGLContext* m_glContext;

Can you use OwnPtr here and avoid the delete calls?

> Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp:64
> +static inline uint64_t createUniqueKey(int layerID, int tileID)

createLayerTileUniqueID

> Tools/qmake/mkspecs/features/features.prf:177
> +	   linux-*:config_libXcomposite: DEFINES += WTF_USE_GRAPHICS_SURFACE=1

DEFINES += HAVE_GLX, maybe even HAVE_XCOMPOSITE