[webkit-reviews] review granted: [Bug 90809] [Qt] [Part 1] platform/qt/css1 tests needs update after rebaseline and new testfonts : [Attachment 151787] Patch for css1/box_properties directory
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 12 05:49:22 PDT 2012
Csaba Osztrogonac <ossy at webkit.org> has granted Luciano Wolf
<luciano.wolf at openbossa.org>'s request for review:
Bug 90809: [Qt] [Part 1] platform/qt/css1 tests needs update after rebaseline
and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=90809
Attachment 151787: Patch for css1/box_properties directory
https://bugs.webkit.org/attachment.cgi?id=151787&action=review
------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
LGTM, r=me. (all tests passed for me locally on wk1 and wk2 too)
But unfortunately images pass only on wk1, there are 30 tests (from 50) with
image fail on WK2 with minor differences.
Please unskip them for wk1 and wk2 too. ;-) When we start running wk2 png
tests, we can commit pngs for them.
More information about the webkit-reviews
mailing list