[webkit-reviews] review granted: [Bug 90768] [WK2][EFL] Facilitate debugging of the Web Process : [Attachment 151614] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 90768: [WK2][EFL] Facilitate debugging of the Web Process
https://bugs.webkit.org/show_bug.cgi?id=90768

Attachment 151614: Patch
https://bugs.webkit.org/attachment.cgi?id=151614&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151614&action=review


> Source/WebKit2/ChangeLog:12
> +	   for debugging purposes with prefixes such as:
> +	   "xterm -title renderer -e gdb --args".

How is this much better than using gdb --args ... and then set follow-fork-mode
child ?

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:261
> +    option_group_definitions.append(("EFL-specific Options", [
> +	   optparse.make_option("--webprocess-cmd-prefix", type="string",
> +	       default=False, help="Prefix used when spawning the Web process
(Debug mode only)"),
> +    ]))
> +

I guess Qt could use this as well? or actually all webkit2 ports