[webkit-reviews] review denied: [Bug 90931] Show or hide <dialog> depending on the open attribute : [Attachment 151653] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Matt Falkenhagen
<falken at chromium.org>'s request for review:
Bug 90931: Show or hide <dialog> depending on the open attribute
https://bugs.webkit.org/show_bug.cgi?id=90931

Attachment 151653: Patch
https://bugs.webkit.org/attachment.cgi?id=151653&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151653&action=review


> Source/WebCore/html/HTMLDialogElement.cpp:68
> +void HTMLDialogElement::attributeChanged(const Attribute& attribute)
> +{
> +    if (attribute.name() == openAttr)
> +	   setNeedsStyleRecalc();
> +    HTMLElement::attributeChanged(attribute);

Is this needed?
I thought we automatically do style-recalc if a stylesheet has [attribute]
selectors.  If we need to do something for it, we should override
isPresentationAttribute().