[webkit-reviews] review granted: [Bug 91003] ASSERT(genChild->isListMarker() || genChild->style()->styleType() == FIRST_LETTER) triggered on flex-box content : [Attachment 151757] Proposed change 1: Do not return the flex box wrapper but search for the proper generated content parent.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 17:34:44 PDT 2012


Abhishek Arya <inferno at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 91003: ASSERT(genChild->isListMarker() || genChild->style()->styleType() ==
FIRST_LETTER) triggered on flex-box content
https://bugs.webkit.org/show_bug.cgi?id=91003

Attachment 151757: Proposed change 1: Do not return the flex box wrapper but
search for the proper generated content parent.
https://bugs.webkit.org/attachment.cgi?id=151757&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151757&action=review


> Source/WebCore/rendering/RenderObjectChildList.cpp:292
>      // Only table parts need to search for the :before or :after parent

Please fix this comment since we now include flexboxes. Probably add a FIXME
that we should instead use isAnonymous to cover any anonymous containers.

> LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox.html:5
> +	   content: 'Generated content wrapped in a flex-box.';

nit: this should be indented right. same for the other test.


More information about the webkit-reviews mailing list