[webkit-reviews] review granted: [Bug 90867] [IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound() : [Attachment 151573] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 15:26:32 PDT 2012


Tony Chang <tony at chromium.org> has granted xingnan.wang at intel.com's request for
review:
Bug 90867: [IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to
true in upperBound()
https://bugs.webkit.org/show_bug.cgi?id=90867

Attachment 151573: Patch
https://bugs.webkit.org/attachment.cgi?id=151573&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
(In reply to comment #2)
> (From update of attachment 151423 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=151423&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +	     No new tests (OOPS!).
> 
> You should remove this line

Actually, you should replace it with a line explaining which tests cover this
change or why it can't be tested.  For this change, it should say something
like:
  No new tests - updated storage/indexeddb/keyrange.html to match new behavior.


More information about the webkit-reviews mailing list