[webkit-reviews] review granted: [Bug 91015] Remove BUILDING_ON / TARGETING macros in favor of system availability macros : [Attachment 151789] Part 1 - Scripted replacement

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 91015: Remove BUILDING_ON / TARGETING macros in favor of system
availability macros
https://bugs.webkit.org/show_bug.cgi?id=91015

Attachment 151789: Part 1 - Scripted replacement
https://bugs.webkit.org/attachment.cgi?id=151789&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151789&action=review


R=me

> Source/WebCore/platform/mac/ScrollElasticityController.mm:75
> -#if defined(BUILDING_ON_LEOPARD) || defined(BULDING_ON_SNOW_LEOPARD) || \
> -    defined(BUILDING_ON_LION) || PLATFORM(CHROMIUM)
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1050 ||
defined(BULDING_ON_SNOW_LEOPARD) || \
> +    __MAC_OS_X_VERSION_MIN_REQUIRED == 1070 || PLATFORM(CHROMIUM)

Might be good to remove the misspelled form of SNOW_LEOPARD.  This could become
__MAC_OS_X_VERSION_MIN_REQUIRED >= 1050

> Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm:47
> -#define HAVE_MEDIA_CONTROL (!defined(BUILDING_ON_LEOPARD))
> +#define HAVE_MEDIA_CONTROL __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060

It feels like having parentheses around this would be good.