[webkit-reviews] review canceled: [Bug 91006] Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client : [Attachment 151769] Patch

[bugzilla-daemon at webkit.org]

Pierre Rossi <pierre.rossi at gmail.com> has canceled Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 91006: Unify numTouchEventHandlersChanged and needTouchEvents in the chrome
client
https://bugs.webkit.org/show_bug.cgi?id=91006

Attachment 151769: Patch
https://bugs.webkit.org/attachment.cgi?id=151769&action=review

------- Additional Comments from Pierre Rossi <pierre.rossi at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151769&action=review


>> Source/WebCore/dom/Document.cpp:5926
>> +	m_listenerTypes &= ~TOUCH_LISTENER;
> 
> Where did this code come from?

Mhh, just trying to make Document::hasListenerType more reliable for TOUCH,
since it's used in other places for that purpose. Worthy of an inline comment
maybe ?

>> Source/WebCore/dom/Document.cpp:5928
>> +	    page->chrome()->client()->needTouchEvents(false);
> 
> What if we had multiple documents (with touch event handlers) in the page?

Good point. I guess I might need to keep the logic at the Frame level just for
that.