[webkit-reviews] review granted: [Bug 9493] Percentage width in 0px container block incorrectly rendered. : [Attachment 151670] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 9493: Percentage width in 0px container block incorrectly rendered.
https://bugs.webkit.org/show_bug.cgi?id=9493

Attachment 151670: Patch
https://bugs.webkit.org/attachment.cgi?id=151670&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151670&action=review


I like the ref test. r=me. Two nits about the image resource: the '-jpeg' in
the filename is redundant, and the resource would likely be smaller as a PNG.

> Source/WebCore/ChangeLog:15
> +	    The containing block is float or positioned in which case the width
of the replace child element must be its instrinsic width.

floated, not float.
replaced, not replace.

> Source/WebCore/ChangeLog:17
> +	    replace elment must be zero. 

replaced, not replace.

> Source/WebCore/rendering/RenderBox.cpp:2200
> +	       // FIXME: Handle cases when containing block width is calculated
or viewport percent.

Please file a bug and mention it here.