[webkit-reviews] review granted: [Bug 90872] Ensure that test_result_writer.copy_file creates the correct directories : [Attachment 151649] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted jochen at chromium.org's request for
review:
Bug 90872: Ensure that test_result_writer.copy_file creates the correct
directories
https://bugs.webkit.org/show_bug.cgi?id=90872

Attachment 151649: Patch
https://bugs.webkit.org/attachment.cgi?id=151649&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151649&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:270
> +	   fs.maybe_make_directory(fs.dirname(dst_filepath))

Do we not need this in the other places in this file where we call
make_output_directory? Do write_text_file/write_binary_file create the
directory for you?

I suppose there's already a test that shows the write_binary_file codepath
works correctly.