[webkit-reviews] review granted: [Bug 90986] Move nodesFromRect tests to separate directory : [Attachment 151723] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 90986: Move nodesFromRect tests to separate directory
https://bugs.webkit.org/show_bug.cgi?id=90986

Attachment 151723: Patch
https://bugs.webkit.org/attachment.cgi?id=151723&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151723&action=review


> LayoutTests/ChangeLog:24
> +	   * media/nodesFromRect-shadowContent.html:

do we want to move this too?

> LayoutTests/platform/chromium/TestExpectations:2163
>  // We don't support layoutTestController.nodesFromRect so this test just
times out

this is inaccurate now since it uses Internals. Maybe it will just work for
most ports as is?

> LayoutTests/platform/win/Skipped:1303
>  # LayoutTestController::nodesFromRect is not supported.

ditto

> LayoutTests/platform/wincairo/Skipped:1818
>  # LayoutTestController::nodesFromRect is not supported.

ditto

> LayoutTests/platform/wk2/Skipped:-902
> -# WebKitTestRunner needs layoutTestController.nodesFromRect

ditto