[webkit-reviews] review denied: [Bug 88070] [Gtk] Process Gtk 3.4 smooth scroll events properly : [Attachment 151697] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied José Dapena Paz
<jdapena at igalia.com>'s request for review:
Bug 88070: [Gtk] Process Gtk 3.4 smooth scroll events properly
https://bugs.webkit.org/show_bug.cgi?id=88070

Attachment 151697: Patch
https://bugs.webkit.org/attachment.cgi?id=151697&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151697&action=review


This patch looks fine for the most part to me, but it looks like it breaks the
mac build.

> Tools/DumpRenderTree/gtk/EventSender.cpp:493
> +    bool paged = false;
> +    if (argumentCount >= 3) {
> +	   paged = JSValueToBoolean(context, arguments[2]);

You don't usage paged outside of this scope so you should declare it in the
inner scope.

> Tools/DumpRenderTree/gtk/EventSender.cpp:496
> +
> +	   // Gtk+ does not support paged scroll events
> +	   g_return_val_if_fail(!paged, JSValueMakeUndefined(context));

This whole thing can just be:

// We do not support paged scrolls yet.
g_return_val_if_fail(argumentCount < 3 || !JSValueToBoolean(context,
arguments[2]), JSValueMakeUndefined(context));

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:402
> +    // not implemented

Should probably read 

// FIXME: Implement this.

as with other files.