[webkit-reviews] review granted: [Bug 89670] Resolve CSS Exclusions shapeInside, shapeOutside properties to Length based WrapShape classes : [Attachment 151604] Updating changelogs

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Bear Travis <betravis at adobe.com>'s
request for review:
Bug 89670: Resolve CSS Exclusions shapeInside, shapeOutside properties to
Length based WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=89670

Attachment 151604: Updating changelogs
https://bugs.webkit.org/attachment.cgi?id=151604&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=151604&action=review


> Source/WebCore/ChangeLog:14
> +	   - Modifying RenderStyle to use length based WrapShape classes,
> +	   rather than the CSSValue CSSWrapShape classes.
> +	   - The translation between WrapShape and CSSWrapShape classes
> +	   is handled by helper functions in the new WrapShapeFunctions files.
> +	   - StyleBuilder resolves CSSWrapShapes to WrapShapes for layout use.
> +	   - CSSComputedStyleDeclaration translates WrapShapes to CSSWrapShapes

> +	   for style use.

You should explain why.

> Source/WebCore/rendering/style/WrapShapes.h:52
> +class WrapShape : public RefCounted<WrapShape> {
> +public:
> +    enum Type {
> +	   WRAP_SHAPE_RECTANGLE = 1,
> +	   WRAP_SHAPE_CIRCLE = 2,
> +	   WRAP_SHAPE_ELLIPSE = 3,
> +	   WRAP_SHAPE_POLYGON = 4
> +    };
> +
> +    virtual Type type() const = 0;
> +    virtual ~WrapShape() { }
> +
> +protected:
> +    WrapShape() { }
> +};

This doesn't really need the vptr. You could make the type a field in the base
and cast to subclass in destructor. This would save some memory (on 64bit) and
avoid the virtual calls.

Not a big deal though.