[webkit-reviews] review granted: [Bug 90843] [chromium] Rename layerRect to contentRect for rects that live in content space : [Attachment 151540] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 10:31:53 PDT 2012


Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 90843: [chromium] Rename layerRect to contentRect for rects that live in
content space
https://bugs.webkit.org/show_bug.cgi?id=90843

Attachment 151540: Patch
https://bugs.webkit.org/attachment.cgi?id=151540&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151540&action=review


Given the mess around surfaces and transforms, I think ironing out those
wrinkles are going to be a little bit more involved.  let's land this and punt
on the surface issue.  R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:60
> +    WebKit::WebTransformationMatrix m_drawTransform;

Can you add a FIXME here that this should be merged into the quad transform in
the shared quad state?


More information about the webkit-reviews mailing list