[webkit-reviews] review granted: [Bug 89990] NodesFromRect doesn't work on SVG root elements : [Attachment 151714] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 09:56:38 PDT 2012


Antonio Gomes <tonikitoo at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 89990: NodesFromRect doesn't work on SVG root elements
https://bugs.webkit.org/show_bug.cgi?id=89990

Attachment 151714: Patch
https://bugs.webkit.org/attachment.cgi?id=151714&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151714&action=review


> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:445
> +	   if (pointInContainer.intersects(boundsRect)) {

I found it hard to read as a 'point' when it is actually an area.


More information about the webkit-reviews mailing list