[webkit-reviews] review canceled: [Bug 90277] Web Inspector: added Paint events for Images to TimelineAgent : [Attachment 151694] Patch

[bugzilla-daemon at webkit.org]

Andrey Kosyakov <caseq at chromium.org> has canceled Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90277: Web Inspector: added Paint events for Images to TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90277

Attachment 151694: Patch
https://bugs.webkit.org/attachment.cgi?id=151694&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151694&action=review


> Source/WebCore/English.lproj/localizedStrings.js:297
> +localizedStrings["Image Decode"] = "Image Decode";
> +localizedStrings["Image Resize"] = "Image Resize";

Image Decode => Decode Image
Image Resize => Resize Image

> Source/WebCore/inspector/TimelineRecordFactory.cpp:185
> +PassRefPtr<InspectorObject>
TimelineRecordFactory::createResizeImageData(bool shouldCache)
> +{
> +    RefPtr<InspectorObject> data = InspectorObject::create();
> +    data->setBoolean("shouldCache", shouldCache);

shouldCache => cached?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:578
> +	       case recordTypes.DecodeImage:
> +		   break;
> +	       case recordTypes.ResizeImage:
> +		   break;

Any reasons why we don't want default branch to run?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:628
> +		   return this.data["shouldCache"] ? "cached" : "non-cached";

use WebInspector.UIString()?

> Source/WebCore/platform/graphics/ImageSource.cpp:150
> +    InspectorInstrumentation::willDecodeImage();
>  
>      ImageFrame* buffer = m_decoder->frameBufferAtIndex(index);
> +    
> +    InspectorInstrumentation::didDecodeImage();

So will this run only when we actually decode image?