[webkit-reviews] review canceled: [Bug 90267] Handle SSL errors for SOUP : [Attachment 151657] Updated patch to address review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 05:01:34 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 90267: Handle SSL errors for SOUP
https://bugs.webkit.org/show_bug.cgi?id=90267

Attachment 151657: Updated patch to address review comments
https://bugs.webkit.org/attachment.cgi?id=151657&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Updated patch to allow saving more than one certificate per host. Instead of
saving the certificate and compare the whole data to check whether it's equal
to another one, I've followed the same approach than chromium, computing and
saving the SHA1 of the certificate data. To make it easiert to add and check
certificates I've used a simpler helper class. This should also fix the EFL
build, adding the new message to LocalizedStrings instead of adding a
translatable string directly.


More information about the webkit-reviews mailing list