[webkit-reviews] review denied: [Bug 90532] Shadow DOM for <img> : [Attachment 151584] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 10 22:36:29 PDT 2012
Hajime Morrita <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 90532: Shadow DOM for <img>
https://bugs.webkit.org/show_bug.cgi?id=90532
Attachment 151584: Patch
https://bugs.webkit.org/attachment.cgi?id=151584&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151584&action=review
It looks this doesn't consider <map> element. But we should.
> Source/WebCore/svg/SVGImageLoader.h:39
> +class DefaultSVGImageLoaderClient : public ImageLoaderClient {
It looks we can hide this to .cpp file and expose only the create function.
> LayoutTests/ChangeLog:17
> +
Let's have a test with @alt text.
More information about the webkit-reviews
mailing list