[webkit-reviews] review requested: [Bug 89670] Resolve CSS Exclusions shapeInside, shapeOutside properties to Length based WrapShape classes : [Attachment 151555] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 10 17:00:17 PDT 2012


Bear Travis <betravis at adobe.com> has asked  for review:
Bug 89670: Resolve CSS Exclusions shapeInside, shapeOutside properties to
Length based WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=89670

Attachment 151555: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=151555&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
Moved WrapShape <-> CSSWrapShape conversions to WrapShapeFunctions .h/.cpp
files. Changed radiusX/Y to cornerRadiusX/Y. Added some non-valid length tests.
The specification does not yet restrict the lengths (eg, negative corner
radii), so not yet testing those.


More information about the webkit-reviews mailing list