[webkit-reviews] review granted: [Bug 90811] Add a performance test for hit testing in SVG : [Attachment 151310] Add a performance test for hit testing in SVG

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 90811: Add a performance test for hit testing in SVG
https://bugs.webkit.org/show_bug.cgi?id=90811

Attachment 151310: Add a performance test for hit testing in SVG
https://bugs.webkit.org/attachment.cgi?id=151310&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151310&action=review


> PerformanceTests/SVG/SvgHitTesting.html:2
> +<!-- Benchmark of SVG Hit Testing -->

Do we really need this comment?

> PerformanceTests/SVG/SvgHitTesting.html:105
> +	 // var checkResults = {'ellipse': 0, 'circle': 0, 'rect': 0, 'path':
0, 'svg': 0, 'use': 0};

NIt: we should remove this.

> PerformanceTests/SVG/SvgHitTesting.html:111
> +	     // checkResults[el.nodeName]++;

Ditto.

> PerformanceTests/SVG/SvgHitTesting.html:113
> +	   // console.log(checkResults);

Ditto.