[webkit-reviews] review granted: [Bug 89108] [Qt][NRWT] Enable cascaded TestExpectations : [Attachment 150897] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 8 11:47:19 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted János Badics
<jbadics at inf.u-szeged.hu>'s request for review:
Bug 89108: [Qt][NRWT] Enable cascaded TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89108

Attachment 150897: proposed patch
https://bugs.webkit.org/attachment.cgi?id=150897&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150897&action=review


> Tools/Scripts/webkitpy/layout_tests/port/qt.py:149
> +	   return paths

Nit: I'd probably write this in one line using a list comprehension:

  return reversed(self._filesystem.join(self._webkit_baseline_path(p),
'TestExpectations') for p in self._search_paths())


More information about the webkit-reviews mailing list