[webkit-reviews] review granted: [Bug 90351] IndexedDB custom bindings missing String type : [Attachment 151152] Patch to implement String

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted George Staikos
<staikos at kde.org>'s request for review:
Bug 90351: IndexedDB custom bindings missing String type
https://bugs.webkit.org/show_bug.cgi?id=90351

Attachment 151152: Patch to implement String
https://bugs.webkit.org/attachment.cgi?id=151152&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151152&action=review


rs=me, please modify the ChangeLog before landing:

> Source/WebCore/ChangeLog:7
> +

Joshuas explanation should be added to the ChangeLog. It's missing the "why"
answers, as discussed recently on webkit-dev.
Just include a line saying that this is covered by existing tests for ports
that use JSC and have IndexDB available - at least that's how I understand it.