[webkit-reviews] review granted: [Bug 90414] Make HTMLCollection RefCounted : [Attachment 150514] Fixed builds
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 7 12:21:53 PDT 2012
Sam Weinig <sam at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 90414: Make HTMLCollection RefCounted
https://bugs.webkit.org/show_bug.cgi?id=90414
Attachment 150514: Fixed builds
https://bugs.webkit.org/attachment.cgi?id=150514&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150514&action=review
> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:122
> + return toJS(exec, thisObj, WTF::getPtr(collection));
Could you use release here?
> Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:80
> + return toJS(exec, thisObj->globalObject(), WTF::getPtr(collection));
Could you use release here?
More information about the webkit-reviews
mailing list