[webkit-reviews] review granted: [Bug 90592] Web Inspector: Clean up FileSystem related code : [Attachment 150892] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 90592: Web Inspector: Clean up FileSystem related code
https://bugs.webkit.org/show_bug.cgi?id=90592

Attachment 150892: Patch
https://bugs.webkit.org/attachment.cgi?id=150892&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150892&action=review


Please rebase and fix style nits before landing.

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:195
> +    RefPtr<TypeBuilder::FileSystem::Entry> result =

RefPtr<TypeBuilder::FileSystem::Entry> result =
TypeBuilder::FileSystem::Entry::create()
    .setUrl(entry->toURL())
    .setName("/")
    .setIsDirectory(true);

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:303
> +	   RefPtr<TypeBuilder::FileSystem::Entry> entryForFrontend =

Ditto.

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:407
> +    RefPtr<Metadata> result =

Ditto.

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:594
> +	   *error = "No frame is available for the request";

You can avoid copy-pasting this string several times by extracting
assertScriptExecutionContextForOrigin method (like assertDocumentLoader in
InspectorPageAgent).

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:664
> +    long long startLL = start ? *start : 0;

startPosition