[webkit-reviews] review denied: [Bug 88906] Tiled drawing means some elements can disappear behind the page : [Attachment 151121] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Dean Jackson
<dino at apple.com>'s request for review:
Bug 88906: Tiled drawing means some elements can disappear behind the page
https://bugs.webkit.org/show_bug.cgi?id=88906

Attachment 151121: Patch
https://bugs.webkit.org/attachment.cgi?id=151121&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151121&action=review


> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:67
> +    [m_tileContainerLayer.get() setName:@"TileCache Container Layer"];

We normally only set layer names in debug.

> Source/WebCore/rendering/RenderLayerBacking.cpp:145
> +	   m_creatingPrimaryGraphicsLayer = true;

I think m_creatingPrimaryGraphicsLayer could just be a static.

> Source/WebCore/rendering/RenderLayerBacking.cpp:176
> +    m_graphicsLayer = createGraphicsLayer(layerName, true);

Not a big fan of the 'true' here.

> Source/WebCore/rendering/RenderLayerBacking.cpp:570
> +	       if (m_containmentLayer && !m_usingTiledCacheLayer) {

I think the m_containmentLayer && !m_usingTiledCacheLayer thing everywhere is
confusing.

Maybe add:
GraphicsLayer* tileCacheFlatteningLayer() const { return m_usingTiledCacheLayer
? m_containmentLayer : 0; }
GraphicsLayer* clippingLayer() const { return !m_usingTiledCacheLayer ?
m_containmentLayer : 0; }

and use them like:

if (GraphicsLayer* clippingLayer = clippingLayer())
  clippingLayer->....