[webkit-reviews] review denied: [Bug 90697] Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect : [Attachment 151099] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 6 12:14:32 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 90697: Web Inspector: CodeGeneratorInspector.py should not generate
statements with no effect
https://bugs.webkit.org/show_bug.cgi?id=90697

Attachment 151099: Patch
https://bugs.webkit.org/attachment.cgi?id=151099&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
This indeed looks too complex for such a small value added. r- per Peter's
comments. 
Unless it is possible to make a one or two lines fix I don't think this is
reasonable.


More information about the webkit-reviews mailing list