[webkit-reviews] review granted: [Bug 90694] Add an API to explicitly call a JavaScript function with args. : [Attachment 151105] updated with corrections from the review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 6 11:20:59 PDT 2012
Yong Li <yoli at rim.com> has granted Benjamin Meyer <ben at meyerhome.net>'s request
for review:
Bug 90694: Add an API to explicitly call a JavaScript function with args.
https://bugs.webkit.org/show_bug.cgi?id=90694
Attachment 151105: updated with corrections from the review
https://bugs.webkit.org/attachment.cgi?id=151105&action=review
------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151105&action=review
LGTM
> Source/WebKit/blackberry/Api/WebPage.cpp:897
> + JSObjectRef fn = obj;
minor: I prefer long names to short ones.
> Source/WebKit/blackberry/ChangeLog:3
> +
> + Add an API to explicitly call a JavaScript function with args.
should we also put webkit bug number here?
More information about the webkit-reviews
mailing list